Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Cleanup] Applet code cleanup #1242

Closed
wants to merge 1 commit into from
Closed

[Code Cleanup] Applet code cleanup #1242

wants to merge 1 commit into from

Conversation

dalcde
Copy link
Contributor

@dalcde dalcde commented Oct 2, 2012

Cleanup includes:

  • Remove trailing whitespaces
  • Replace tabs with spaces
  • Don't use try/catch in _init as applet manager already does that
  • Proper use of ";' and ","

Certain applets have pull requests pending and are not included in cleanup.
These include:

  • Window list
  • Show Desktop
  • Menu
  • Notifications

Diff (ignore-all-space): http://pastebin.com/Bh3JeZMn

- Remove trailing whitespaces
- Replace tabs with spaces
- Don't use try/catch in _init as applet manager already does that

Certain applets have pull requests pending and are not included in cleanup.
These include:
- Window list
- Show Desktop
- Menu
- Notifications
@autarkper
Copy link
Contributor

This conflicts with #1259.

@autarkper
Copy link
Contributor

I have merged this to my master branch.

@AlbertJP
Copy link
Contributor

This pull request can't be automatically merged. Probably it conflicts with something from yesterday's merge party.

@dalcde dalcde closed this Jan 8, 2013
@dalcde dalcde reopened this Jan 8, 2013
@dalcde
Copy link
Contributor Author

dalcde commented Jan 15, 2013

Closing for now.

@dalcde dalcde closed this Jan 15, 2013
@Cobinja Cobinja mentioned this pull request Feb 1, 2013
@dalcde dalcde deleted the cleanup/applets branch December 21, 2014 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants